fix(web): 修复 uni.showActionSheet 的参数 popover.width 设置无效的问题 (question/189745) #4849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
popover 参数仅在 web pc 端有效，此前 popover.width 设置参数无效，并且 popover.left 参数 设置与实际值有偏差（差150px），三角形位置也可能不对，本次提交修复了这三个问题。
主要修改了 usePopupStyle 方法，此方法除了 uni.showActionSheet 用到还有 picker 组件用到，所以 在此方法加了第二个参数判断是否是动态宽度，picker组件依然固定宽度300px，不影响 picker 组件功能