Split JoinToTimeSpineNode into two nodes
#1477
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can get this info from one of the other params.
courtneyholcomb
changed the title
JoinToTimeSpineNode into two nodes
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
1 similar comment
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
…or time spines The metric time nodes are used for resolving metric_time without metrics. The read SQL nodes will be used for time spine joins.
…ace_time_dimension_specs
courtneyholcomb
force-pushed
the
court/split-time-spine-nodes
branch
from
6426287
to
1e90418
Compare
courtneyholcomb
force-pushed
the
court/split-time-spine-nodes
branch
from
1e90418
to
017dbd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can get this info from one of the other params.