Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pandas / numpy Dependency From metricflow-semantics #1189

Closed
wants to merge 13 commits into from
Closed

Remove pandas / numpy Dependency From metricflow-semantics #1189

wants to merge 13 commits into from

Conversation

plypaul
Copy link
Contributor

@plypaul plypaul commented May 8, 2024 •
edited
Loading

Description

metricflow-semantics currently is dependent on pandas and transitively, numpy. It would be helpful to remove those dependencies as:

  • They often have hard version requirements due to backward-incompatible changes.
  • They pull in many dependent packages.
  • They are large packages that slow down building of the virtual environment and consume significant memory when loaded.

Removing those dependencies would make the package easier to use. Migrading away from pandas requires changing the implementation of time period calculations to use dateutil..

plypaul added 13 commits May 8, 2024 04:21
@plypaul
/* STACK_START p-rm-pandas 01 */ Add directory anchors for all semant…
f5336a6 
…ics manifests.
@plypaul
Update test fixtures to load manifests using paths from anchors.
385a6c8
@plypaul
Move example_project_configuration.py to test_helpers.
627065d
@plypaul
Remove unused SQLAlchemy-related classes.
2e97f8a
@plypaul
/* PR_START 02 */ Move pandas / time-period calls to an interface.
aea6198 
Some functions in `TimeConstraint` were moved to the interface.
Additional helpers that use `pandas` will be migrated in the next
commit.
@plypaul
Move additional helpers that use pandas.
7cca903
@plypaul
Add DateutilTimePeriodAdjuster.
75f8425
@plypaul
Migrate existing use cases to DateutilTimePeriodAdjuster.
24cec1a
@plypaul
Removed unused methods.
f3827ff
@plypaul
Move pandas_adjuster.py to tests_metricflow_semantics.
26464a4
@plypaul
Skip tests requring pandas by default.
84d1f8d
@plypaul
Remove pandas dependency from metricflow-semantics.
21db8a3
@plypaul
Lint fixes.
5057a0c
@cla-bot cla-bot bot added the cla:yes label May 8, 2024
@plypaul plypaul mentioned this pull request May 8, 2024
Closed
@plypaul plypaul marked this pull request as ready for review May 8, 2024 11:37
@plypaul plypaul force-pushed the p-rm-pandas--01 branch 2 times, most recently from 90356ae to 8c2c086 Compare May 30, 2024 00:12
Base automatically changed from p-rm-pandas--01 to main May 30, 2024 00:16
@plypaul
Copy link
Contributor Author

plypaul commented May 30, 2024

Closing this out as this was significantly revised, and related changes will be in a another PR.

@plypaul plypaul closed this May 30, 2024
@plypaul plypaul deleted the p-rm-pandas--02 branch May 31, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla:yes Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@plypaul