New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use XDG conventions on macOS too #319
base: main
Are you sure you want to change the base?
Conversation
Hi, thanks for the PR. Some questions before I take a closer look:
|
Ugh, looks like app_dirs2 doesn't follow the convention on Windows of most other "dirs" crates out there. Linux users won't be affected, but I can modify the code to retain the same behavior on Windows. I don't use CLI tools on Windows, so I've no strong opinions about it. No, right now this PR makes no effort to maintain backward compatibility on macOS. IMO, no macOS users expect the config file to be located in |
2ccb5b8
to
715af6f
Compare
Fixed & test on Windows:
|
I should mention that is weird that app_dirs2 uses the same location for cache & user data. The popular |
@dbrgn If you want, I can add a fallback to |
@dbrgn ping |
Let's discuss the transition period in the issue thread first :) |
Fixes #311.