-
Notifications
You must be signed in to change notification settings - Fork 969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using self.next_run.time() instead of self.at_time when "making sure we run at the specified time *today*" #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ird behavior, e.g. not accounting for daylight saving
AnezeR
changed the title
Applying timezone to self.at_time
Using self.next_run.time() instead of self.at_time when "making sure we run at the specified time *today*"
Apr 28, 2023
Co-authored-by: Sijmen <[email protected]>
@SijmenHuizenga, is this why the tests are failing, or is there something with the code? |
Hi, Is there an ETA on this issue? Thanks. |
Can this get merged and released? This is a very serious bug. |
Would be great to get this in. Is there an estimate for when it will merge? Thanks! |
SijmenHuizenga
approved these changes
Oct 1, 2023
This was referenced Oct 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An if-statement that subtracts a day from self.next_run was using self.at_time (a value not affected by timezone).
Thus, when applying timezone to self.next_run a day was incorrectly subtracted, like in #582 (comment) or, on the opposite, not subtracted, like in #579 (comment).
Tests for these issues are added as well.