Arithmetics #10
Open
Arithmetics #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd average of a single column, added convenience usings. Beware: We should consider convert_up for all data types and perform sum/average on the largest respective integral or floating point type.
…or arithmetic implementation
…definition for 1 column arithmetic
Moved assignment of element_count to the case that handles the average operation to avoid unused warnings (Wunused)
There was a problem hiding this comment.
Do we want to provide operator() with valid masks?
There was a problem hiding this comment.
It only makes sense for reduction, i.e. single column operators. In these cases -- yes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an arithmetic class, which calculates...
We also provide convenience using definitions, which have to be templated with the appropriate tsl::VectorProcessingStyle by the user.
Unit tests for all of the above have been added.