New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert improperly compares number of columns and value columns #27

Open

balint-balku-scraperapi wants to merge 1 commit into db-migrate:master from balint-balku-scraperapi:patch-2

balint-balku-scraperapi commented Jan 4, 2021

Insert performs an improper check when multiple columns and multiple rows of data passed to the call.

Example:

insert('table_name',
  [ 'column1', 'column2' ],
  [ [ 'row1_col1', 'row1_col2' ], [ 'row2_col1', 'row2_col2' ], [ 'row3_col1', 'row3_col2' ] ]
);

The above should be ok as the number of columns matches the number of value-columns, but it does throw an error in the current implementation.


Insert improperly compares number of columns and value columns

701a528

Signed-off-by: Balint Balku <[email protected]>

balint-balku-scraperapi force-pushed the patch-2 branch from 619e8d0 to 701a528 Compare

January 4, 2021 14:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment