dinit-log: Add text color #334
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a PR. To accept this I would require a few changes: since the color sequences are not universal to every terminal, and since some people wouldn't want them anyway, there should be a (documented) way to turn them off (i.e. a command-line argument). Additionally I would like the escape sequences to named macros or constants rather than embed them directly in the message strings. |
mobin-2008
added
Enhancement/New Feature
mobin-2008
reviewed
May 25, 2024
| @@ -0,0 +1,238 @@ | |||
| # This is the build file for project "dinit" | |||
There was a problem hiding this comment.
Looks like you pushed everything that was in your git working dir.
mobin-2008
reviewed
May 25, 2024
Comment on lines
+9
to
+12
| #define COLOR_GREEN "\x1b[32m" // green | ||
| #define COLOR_RED "\x1b[33m" // red | ||
| #define COLOR_YELLOW "\x1b[31m" // yellow | ||
| #define COLOR_RESET "\x1b[0m" // reset |
There was a problem hiding this comment.
"// green" comment and similar comments are unnecessary, Names are self-explanatory.
|
Other than cleaning up the PR so that it doesn't include a bunch of built files (as Mobin pointed out):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just added a couple of lines so that the logging was colored :D