Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for Bootstrap v5 #1254

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix for Bootstrap v5 #1254

wants to merge 1 commit into from

Conversation

mat-dr
Copy link

@mat-dr mat-dr commented Mar 24, 2023

No description provided.

@rgelb
Copy link

rgelb commented Mar 30, 2023

This fixes it partially. The calling HTML page needs to have a reference to the popper.js library as its now required for bootstrap 5 dropdowns.

@mat-dr
Copy link
Author

mat-dr commented Mar 30, 2023

Yes it requires Popper. It is also possible to only include the Bootstrap .js file that includes Popper (bootstrap.bundle.min.js, as in https://getbootstrap.com/docs/5.2/getting-started/introduction/).

@Taikono-Himazin
Copy link

I'm sorry, but could you merge it and release it as bootstrap-multiselect-v2.0.0?
That's all there is to it.

@tiesont
Copy link
Collaborator

tiesont commented Jun 1, 2023

That's all there is to it.

Not really.

Feel free to fork the repo and merge any changes you're comfortable using, if you really want this or other pull-requests.

@utilmind
Copy link

@mat-dr Thank you for this PR! It works great on BS5 with your fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mat-dr @rgelb @Taikono-Himazin @tiesont @utilmind