Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: divider causes optGroup to become unchecked incorrectly #1022

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: divider causes optGroup to become unchecked incorrectly #1022

wants to merge 1 commit into from

Conversation

jstrawther
Copy link

@jstrawther jstrawther commented Jun 4, 2018

To reproduce...

  1. Create a multiselect with multiple optgroups separated by dividers.
  2. Select all options in an optgroup. Header is checked.
  3. Call deselect method to deselect array of items by value from another optgroup.
  4. The first optgroup is automatically deselected, even though all options are still selected.

Issue:
Examine the call to updateOptGroups on line 1369. When determining checked property of each optGroup, the divider option is included in the $options collection for consideration; but it should not be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant