Idea on how to improve raw ingridients search #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How does this handle the scenario where USDA is disabled? I think the OFF only option barcode scans should only be available is USDA is enabled. |
|
Updated the PR to only respect this option when USDA is enabled. Ideally the toggle in the settings should be disabled, but I do not know how to do that. This PR is mostly to give you an idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an idea on how to improve raw ingredients search when user has both OFF and USDA integrations configured after the conversation in issue #799 .
The idea here is to use OFF only for the barcode scans and any search by product name will only return USDA results.
I do not know how to test it, but the change seems simple enough to me. Feel free to treat this PR as a simple idea that you may certainly improve upon.