Switch yarn for npm
#481
Open
Switch yarn for npm
#481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can't `pnpm install` without declaring this. The repo uses `yarn` and that still works so maybe it's OK without but it seems more correct to declare it if it's necessary in a more strict package manager...
The current setup requires `yarn` to be installed in order to build this repo. For the `pixi-v8` branch I'm pointing my app directly at the branch via: `"pixi-viewport": "git+https://github.com/vitch/pixi-viewport#pixi-v8"` This works fine locally (where I installed `yarn`) but fails on CI. So this commit attempts to remove the dependency on `yarn`. Note I also had to lock `electron` to a version compatible with the `peerDependency` declared by `floss` (which afaict is the only reason `electron` is here).
|
This is working OK in my project in that I can point at this branch and CI can now build I'm aware that these changes could be subjective and I'm not necessarily asking for them to be merged. The usage of |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(targets #480 - only the last commit on this branch is relevant but I couldn't see how to target another branch on my fork?)
The current setup requires
yarnto be installed inorder to build this repo.
For the
pixi-v8branch I'm pointing my app directlyat the branch via:
"pixi-viewport": "git+https://github.com/vitch/pixi-viewport#pixi-v8"This works fine locally (where I installed
yarn)but fails on CI. So this commit attempts to remove the
dependency on
yarn.Note I also had to lock
electronto a version compatiblewith the
peerDependencydeclared byfloss(whichafaict is the only reason
electronis here).