Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/front-end-robustness-improvements #121

Merged
merged 15 commits into from
Mar 26, 2024
Merged

feat/front-end-robustness-improvements #121

merged 15 commits into from
Mar 26, 2024

Conversation

GaspardBBY
Copy link
Contributor

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 7, 2024
View reviewed changes
expo/app/(tabs)/rooms/[id]/add.tsx Fixed Show fixed Hide fixed
expo/components/ErrorBoundary.js Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 12, 2024
View reviewed changes
expo/app/(tabs)/rooms/[id]/_layout.tsx Fixed Show fixed Hide fixed
expo/app/(tabs)/rooms/[id]/_layout.tsx Fixed Show fixed Hide fixed
expo/app/(tabs)/rooms/[id]/_layout.tsx Fixed Show fixed Hide fixed
expo/app/(tabs)/rooms/[id]/add.tsx Fixed Show fixed Hide fixed
@GaspardBBY GaspardBBY self-assigned this Mar 16, 2024
@GaspardBBY GaspardBBY linked an issue Mar 17, 2024 that may be closed by this pull request
Améliorer la robustesse du front #114
Closed
@GaspardBBY GaspardBBY marked this pull request as ready for review March 21, 2024 18:37
@GaspardBBY GaspardBBY added the feature Issues that plan on adding features label Mar 21, 2024
@GaspardBBY GaspardBBY added this to the Itération 6 milestone Mar 21, 2024
@GaspardBBY GaspardBBY added the frontend Frontend related issues label Mar 22, 2024
MAXOUXAX
MAXOUXAX requested changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@MAXOUXAX MAXOUXAX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very few changes, looking good :)

backend/src/musicplatform/TrackMetadata.ts Outdated Show resolved Hide resolved
backend/src/musicplatform/remotes/SpotifyRemote.ts Outdated Show resolved Hide resolved
backend/src/musicplatform/remotes/SpotifyRemote.ts Outdated Show resolved Hide resolved
backend/src/musicplatform/remotes/SpotifyRemote.ts Outdated Show resolved Hide resolved
backend/src/musicplatform/remotes/SpotifyRemote.ts Outdated Show resolved Hide resolved
backend/src/musicplatform/remotes/SpotifyRemote.ts Outdated Show resolved Hide resolved
backend/src/route/AuthCallbackGET.ts Outdated Show resolved Hide resolved
backend/src/route/AuthCallbackGET.ts Outdated Show resolved Hide resolved
expo/app/(tabs)/rooms/[id]/_layout.tsx Show resolved Hide resolved
expo/app/(tabs)/rooms/[id]/_layout.tsx Outdated Show resolved Hide resolved
@MAXOUXAX MAXOUXAX linked an issue Mar 25, 2024 that may be closed by this pull request
Améliorer la robustesse du backend #113
Open
This was unlinked from issues Mar 25, 2024
Améliorer la robustesse du backend #113
Open
Améliorer la robustesse du front #114
Closed
@GaspardBBY GaspardBBY force-pushed the feat/front-end-robustness-improvements branch from 0aa62b1 to 4f19789 Compare March 26, 2024 15:16
@GaspardBBY
feat: added ErorrBoundary
9ec34db
@GaspardBBY
chore: updated gitignore when build android app
5bea5d0
@GaspardBBY
fix: tricks to make export work statically (ErrorBoundary not working…
4ff53df 
… on dev mode)
@GaspardBBY
feat: first versiuon of ErrorBoundary class
03c228b
@GaspardBBY
feat: handle websocket disconnexions
f59b846
@GaspardBBY
feat: added hook asyncError to upgrade ErrorBoundary to handle fetch …
d1b0406 
…error
@GaspardBBY
chore: refactor WebsocketError in component
0fe4988
@GaspardBBY
feat: added RootErrorBoundary page
36dd950
@GaspardBBY
refactor: error boudary template became component
4a49997
@GaspardBBY
Fix/remote token provider (#128)
461e62a 
* chore: added method room:error in websocket ServerToClient

* fix: catched Spotify SDK error & fix

* fix: on remote creation, added bound services verification
@GaspardBBY
chore: removed hardcode default fallback error page
772ca1d
@GaspardBBY
fix : type of props in ErrorBoundary
f355d7e
@GaspardBBY
chore : resolved conflicts
f1c0acc
@GaspardBBY
fix: duplicated import
a104017
@GaspardBBY GaspardBBY force-pushed the feat/front-end-robustness-improvements branch from 4f19789 to a104017 Compare March 26, 2024 15:49
MAXOUXAX
MAXOUXAX approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@MAXOUXAX MAXOUXAX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MAXOUXAX
MAXOUXAX approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@MAXOUXAX MAXOUXAX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MAXOUXAX MAXOUXAX merged commit eb732e0 into main Mar 26, 2024
3 checks passed
@MAXOUXAX MAXOUXAX deleted the feat/front-end-robustness-improvements branch March 26, 2024 15:55
@GaspardBBY GaspardBBY linked an issue Mar 26, 2024 that may be closed by this pull request
Améliorer la robustesse du front #114
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MAXOUXAX MAXOUXAX MAXOUXAX approved these changes

@TheRealSharKzy TheRealSharKzy Awaiting requested review from TheRealSharKzy

Assignees

@GaspardBBY GaspardBBY

Labels
feature Issues that plan on adding features frontend Frontend related issues
Projects
None yet
Milestone
Itération 6
Development

Successfully merging this pull request may close these issues.

Améliorer la robustesse du front
2 participants
@GaspardBBY @MAXOUXAX