Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ECharts performance #518

Merged
merged 1 commit into from
Sep 12, 2024
Merged

fix: ECharts performance #518

merged 1 commit into from
Sep 12, 2024

Conversation

dvmoritzschoefl
Copy link
Contributor

@dvmoritzschoefl dvmoritzschoefl commented Sep 11, 2024 •
edited
Loading

DRAFT PR

Closes (#516)

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified (tag assignees)
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

Screenshots

Additional notes for the reviewer(s)

Thanks for creating this pull request 🤗

@dvmoritzschoefl dvmoritzschoefl changed the base branch from develop to och/bar-chart-react-window September 11, 2024 11:51
oltionchampari
oltionchampari approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@oltionchampari oltionchampari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks looks good

@oltionchampari oltionchampari marked this pull request as ready for review September 12, 2024 11:10
@oltionchampari oltionchampari requested a review from a team as a code owner September 12, 2024 11:10
@oltionchampari oltionchampari merged commit f3b5322 into och/bar-chart-react-window Sep 12, 2024
12 of 16 checks passed
@oltionchampari oltionchampari deleted the mh/echarts_sort_performance branch September 12, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oltionchampari oltionchampari oltionchampari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvmoritzschoefl @oltionchampari