-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bar chart selection #497
base: develop
Are you sure you want to change the base?
Conversation
…r-chart-using-echarts
- make group value default - harmonize bar width/height
(cherry picked from commit 8e4a0ea)
…r-chart-using-echarts
Fixes datavisyn/communication_xaira_ordino#26 The ReactECharts component will check the resize of the parent element and update accordingly
* fix: make resizing work for facets * feat: add a loading overlay when the viewport resizes * fix: scroll flickering * fix: remove pos relative * chore: remove unnecessary overflow hidden * chore: address PR review * fix: storybook error
* feat: add sorting controls wip: add sorting for y axis wip: add property in config to preload sorting wip: use in reprovisyn * feat: improvements in sorting * feat: handle categorical column change * feat: implement initial sorting * feat: move sort into the header * fix: sort for normalized mode * chore: sort facets by name * fix: add null check for sortState * fix: add null checks for sort button * fix: fallback value * fix: remove circular dependency * fix: address PR feedback * chore: use color for unknown values * fix: storybook error
…olcano (#486) * feat: add sorting controls wip: add sorting for y axis wip: add property in config to preload sorting wip: use in reprovisyn * feat: improvements in sorting * feat: handle categorical column change * feat: implement initial sorting * feat: move sort into the header * fix: sort for normalized mode * chore: sort facets by name * fix: add null check for sortState * fix: add null checks for sort button * fix: fallback value * fix: remove circular dependency * fix: address PR feedback * chore: use color for unknown values * fix: storybook error * fix: overlapping legends in bar chart * chore: update SingleEChartsBarChart.tsx
…o thinkh/refactor-bar-chart-using-echarts
@dv-usama-ansari Currently open tasks:
|
wip: selection does not work
…/visyn_core into ua/bar-chart-selection
@thinkh
I made this ☝️ work in a way we would expect to see the truncation in DOM elements. We now have a constant to define the maximum label width in pixels and the component would handle truncated text automatically: visyn_core/src/vis/bar/constants.ts Line 24 in 3f2337e
As of 3f2337e, I still have to fix the heights of individual charts when the group type is I would document this in detail in this PR very soon. |
It was a tricky implementation but according to 13b22fc, the bar plot labels are now responsive like we saw in the PowerBI dashboard responsive-labels-bar-plot.webm |
Follow up of #438
Developer Checklist (Definition of Done)
Issue
UI/UX/Vis
Code
PR
release: minor
) to this PR following semverCloses #...
)Summary of changes
Screenshots
Additional notes for the reviewer(s)