Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

echarts bar chart performance improvements #516

Open
3 tasks
thinkh opened this issue Sep 11, 2024 · 3 comments
Open
3 tasks

echarts bar chart performance improvements #516

thinkh opened this issue Sep 11, 2024 · 3 comments
Assignees
Labels
type: feature New feature or request

Comments

@thinkh
Copy link
Member

thinkh commented Sep 11, 2024

Coming from #497 (review) we still have some performance issue when rendering a large number of categories, groups, and/or facets. It also depends on the number of items per category, group, facet that needs to be processed (e.g., calculate the avg, ...). The performance get's noticably worse when sorting the bar chart. Please check if the performance can be improved for these kind of datasets.

Some suggestions (but not complete) for performance improvements:

  • virtualization per facet -> improves the performance for large number of facets (@oltionchampari started with this)
  • avoid re-render the whole chart when sorting is applied to the config and default; the chart is rendered in the initial order and then re-rendered when the sorting finishes
  • update the bar chart on the fly with dynamic data update, which might be faster than re-rendering the whole chart from scratch
@thinkh thinkh added the type: feature New feature or request label Sep 11, 2024
@thinkh
Copy link
Member Author

thinkh commented Sep 11, 2024

See also my related comment about animations and merging the series data.

@oltionchampari
Copy link
Contributor

@dvmoritzschoefl One use case that we need to support (currently) is having a bar with 10k+ bars. Currently, this freezes the application and then crashes.

@dvmoritzschoefl
Copy link
Contributor

@oltionchampari @thinkh for coordination:
I made a PR on ollys branch that fixes some virtualization issues. Previously when the config changed all plots were remounted caused some flickering
https://github.com/datavisyn/visyn_core/pull/518/files

oltionchampari added a commit that referenced this issue Sep 12, 2024
**DRAFT PR**


Closes (#516)

### Developer Checklist (Definition of Done)

**Issue**

- [ ] All acceptance criteria from the issue are met
- [ ] Tested in latest Chrome/Firefox

**UI/UX/Vis**

- [ ] Requires UI/UX/Vis review
  - [ ] Reviewer(s) are notified (_tag assignees_)
  - [ ] Review has occurred (_link to notes_)
  - [ ] Feedback is included in this PR
  - [ ] Reviewer(s) approve of concept and design

**Code**

- [ ] Branch is up-to-date with the branch to be merged with, i.e.,
develop
- [ ] Code is cleaned up and formatted
- [ ] Unit tests are written (frontend/backend if applicable)
- [ ] Integration tests are written (if applicable)

**PR**

- [ ] Descriptive title for this pull request is provided (will be used
for release notes later)
- [ ] Reviewer and assignees are defined
- [ ] Add type label (e.g., *bug*, *feature*) to this pull request
- [ ] Add release label (e.g., `release: minor`) to this PR following
[semver](https://semver.org/)
- [ ] The PR is connected to the corresponding issue (via `Closes #...`)
- [ ] [Summary of changes](#summary-of-changes) is written


### Summary of changes

- 

### Screenshots


### Additional notes for the reviewer(s)

-  
Thanks for creating this pull request 🤗
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants