-
-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ConvertTo-DbaDataTable handle Dataplat.Dbatools.Utility.DbaDateTime as an array #9361
Conversation
Ok I wondered how this was working because it wasn't working for me locally either - I've changed this to make sense (in my mind) and also updated the null one |
oh sweet, we ready? thank you so much! i cant publish till i get home bc of the hardware key but happy to prep with a merge. |
re-read and indeed. thanks again 🙇🏼 |
okay that's weird, we have a test that passed but then when it merged, it failed?
|
I skipped it in dev since its causing all of our branches to fail |
Hey @potatoqualitee - I'm in Lisbon to see Taylor swift tonight 😂 but I'll take a look at this! It did pass locally and on the branch before merge 🤔 |
HEYYY enjoy taylor swift!!! we can look at this later 😊 |
I created a new branch off develoment and removed the https://github.com/dataplat/dbatools/tree/testingtests https://ci.appveyor.com/project/dataplat/dbatools/builds/49936347 Is it worth uncommenting in development and seeing what happens? If not we can maybe troubleshoot and fix forward? Honestly it's kind of a weird test anyway - we already test string values get converted ok - so I'm not sure what this is adding. Context "Property: myObject" {
It 'Has a column called "myObject"' {
$result.Columns.ColumnName | Should -Contain 'myObject'
}
It 'Has a [string] data type on the column "myObject"' {
$result.myObject | Should -BeOfType [System.String]
}
} |
Type of Change
.\tests\manual.pester.ps1
)Commands to test