-
-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt redesigned version of the lesson #887
Draft
tobyhodges
wants to merge
28
commits into
datacarpentry:main
Choose a base branch
from
datacarpentry:main
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ator/R-ecology-lesson Co-authored-by: Michael Culshaw-Maurer <[email protected]>
Applying Michael's redesign
include episodes/data directory
As recommended by Curriculum Advisors at July 2023 meeting.
…lots add call for beta tests
Update workflows
tobyhodges
added
the
status:wait
Progress dependent on another issue or conversation
label
Mar 26, 2024
|
Remove the curly braces from the fenced code block (curly braces indicate executable chunks in knitr and Quarto).
The section on required packages referenced a heading on the homepage that is outdated
Forcats 1.0.0 depreciated `fct_explicit_na` Equivalent way is now `fct_na_value_to_level(sex, "(Missing)")` Fixes/addresses #11
Fix code block and reference
fct_explicit_na deprecated using fct_na_value_to_level instead
Update data link to refer to current repo
manually update lesson dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As detailed in #886 and https://carpentries.org/blog/2024/03/dc-r-ecology-adoption/, this will replace the current version of the lesson with the redesigned version created by @MCMaurer and approved by @datacarpentry/curriculum-advisors-ecology.
To be merged 2024-07-08