Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): join predict use cast_expr_to_non_null_boolean #16937

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Nov 25, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. join predict use cast_expr_to_non_null_boolean
  2. Improve Buffer index value
bench_kernels/function_buffer_index_unchecked_iterator/10240
                        time:   [4.5793 µs 4.6071 µs 4.6383 µs]
                        change: [-48.367% -47.735% -47.131%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 11 outliers among 100 measurements (11.00%)

closes #16916

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Nov 25, 2024
@andylokandy andylokandy added this pull request to the merge queue Nov 25, 2024
Merged via the queue into databendlabs:main with commit 04df094 Nov 25, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: join on panic caused by invalid data type
2 participants