Drop casting which is effectively a no-op
#6101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In both of these cases `mv` is simply being cast to a `format` (and `shape`) that it already is. Though this was an accidental overwrite by a previous bug fix PR. The code previously tried to maintain `mv`'s `format` and `shape` before performing a copy. While that behavior could be restored, the current behavior has been unchanged for over a year. This indicates the `cast`ing was likely unnecessary to begin with. So just drop it. If we find we need it after all, it is easy to add correctly, which require different code than what is here anyways.
|
Thoughts on this @dask/maintenance? 🙂 |
|
@jakirkham , I started #6104 . There are plenty of typos to grab yet, but I suppose this is the way forward. |
|
@jakirkham , so sorry, this is in the wrong place. Never mind, now you know! :) |
|
Going to go ahead and merge since this code isn't doing anything anyways. Can always follow up if I've missed something though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In both of these cases
mvis simply being cast to aformat(andshape) that it already is. Though this was an accidental overwrite by a previous bug fix PR. The code previously tried to maintainmv'sformatandshapebefore performing a copy. While that behavior could be restored, the current behavior has been unchanged for over a year. This indicates thecasting was likely unnecessary to begin with. So just drop it. If we find we need it after all, it is easy to add correctly, which require different code than what is here anyways.pre-commit run --all-files