Ensure that repack collections only return tuple if necessary #11004
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hit this more often than I'd care to admit when trying to write the dask-expr scheduler integration. This integration inevitably has to touch the code that is dealing with collections parsing and this is part of it.
What's most concerning is that this unpack/repack code is not used consequently such that the unpack/repack in distributed, for instance, is behaving differently than the dask/dask equivalents.
Most endusers will notice this change iff they are using base functions
optimize
,persist
,compute
, etc. Most users will not interact with this but instead with the methods on the collections.This will help me streamline implementation a little and I'm sure that new users will appreciate this. However, I'm very certain this will cause mild breakage somewhere.