Feature/game engine #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Add main game -Add base class ModeGame -Add mode class ClassicGame -Add Player struct -Add some docs
-docs -testing main (for now) -main class Game -ModeGame (ClassicGame, RandomShotGame, ExtendClassicGame) -struct Player
add json add test add GameSettings changing in Game and ModeGame
-change main to only test -transfer libs to test -update docs
delipl
requested changes
Mar 19, 2022
-set in platformio.ini to use esp setup -rename folder to DartEngine -transfer nlohmann/json to lib folder -change subfolder doctest to internal lib (for linux) -little changes in Game and GameSettings -corrent docs / add examples -marge from main
delipl
reviewed
Mar 28, 2022
lib/DartEngine/ClassicGame.hpp
Outdated
| { | ||
| public: | ||
| ClassicGame(); | ||
| virtual Player createPlayer(unsigned int id) const; |
There was a problem hiding this comment.
Can you add override after overridden method's declaration?
I prefer to mark the override because then I don't have to scroll between files and check every method. It is simpler to read.
| @@ -0,0 +1,40 @@ | |||
| #include <DartEngine/Game.hpp> | |||
|
|
|||
| nlohmann::json save_settings = nlohmann::json::parse(R"({ | |||
There was a problem hiding this comment.
As I understand R"" prefix provides to create a multiline string yes? Am I right?
There was a problem hiding this comment.
it's R"()" and you right.
Here is docs: https://en.cppreference.com/w/cpp/language/string_literal
| @@ -0,0 +1 @@ | |||
| include json.hpp before Arduino.h, because Arduino makes define some of variables which is use in json.hpp | |||
There was a problem hiding this comment.
Maybe add the link to their repository?
There was a problem hiding this comment.
what do you mean exactly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think its final version of engine