Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update beta and main pub dependencies #3114

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Update beta and main pub dependencies #3114

merged 3 commits into from
Jan 8, 2025

Conversation

parlough
Copy link
Member

@parlough parlough commented Jan 7, 2025

This PR pins dart_flutter_team_lints for now, as it results in an inclusion error as the SDK constraint is not yet ^3.7.

Copy link

github-actions bot commented Jan 7, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/samples/lib/brick_breaker.dart
pkgs/samples/lib/fibonacci.dart
pkgs/samples/lib/google_ai.dart
pkgs/samples/lib/hello_world.dart
pkgs/samples/lib/main.dart
pkgs/samples/lib/sunflower.dart

@parlough parlough requested review from devoncarew and johnpryan and removed request for devoncarew January 7, 2025 23:00
Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm w/ two notes for backing out the pinning once the next stable sdk is out

pkgs/dart_services/pubspec.yaml Show resolved Hide resolved
pkgs/dartpad_shared/pubspec.yaml Show resolved Hide resolved
@parlough parlough force-pushed the misc/pub-dep-updates branch from ea89ea7 to 2841f3f Compare January 8, 2025 05:36
@parlough parlough merged commit 945d461 into main Jan 8, 2025
15 checks passed
@parlough parlough deleted the misc/pub-dep-updates branch January 8, 2025 05:45
@johnpryan
Copy link
Contributor

Thanks @parlough!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants