-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented autosave on a 5-second timer #3037
Conversation
@parlough I fixed the double quotes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet! Thanks so much for implementing this again :D
@parlough Any updates? |
Sorry for the annoying pings, just want to make sure this doesn't slip between the cracks |
@Levi-Lesches Sorry for the delay, I've been away. The change looks good to me, but before landing, we need to wait for others to determine DartPad's storage policies and how we will inform users of them. I'll land this PR when able and ping you if any changes are needed. Thanks again! |
Hi @parlough, any updates? |
We added a cookie banner now (#3097), so we should be OK to use local storage. |
I'm trying to add an integration test that tests:
This will complicate CI a bit, so I'm updating the README with instructions from the Flutter docs. |
I ended up going with unit tests instead as I couldn't get the integration tests to work: The test cases above are still tested, though, so I'm ready for another review. EDIT ...okay, now I'm ready. I didn't add tests for:
|
Hey, bumping this again |
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
This reverts commit c952120.
Forgot -- the tests don't work with web-only imports. Try running the CI now |
Fixes #2871 by saving the editor content to local storage under they key
user_input
every 5 seconds, and indispose
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.