Add versions to mypy hook's additional dependencies #321
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was recently introduced to Ward, and I really like the look and feel of it! I like to write my tests with mypy's strict mode, so I wanted to see if I could help with things like #261.
In the meantime, my freshly cloned copy of this repository would not pass
mypy
checking. Upon investigation, the project depends onrich@^10.0.0
, but the pre-commitmypy
hook was pulling down latest due to a lack of a version spec. Sincerich
had breaking changes between10
and its current of12
, type checking errors were triggered.This little PR copies the version specs for non-stub typed dependencies from those specified in
pyproject.toml
over to theadditional_dependencies
section in.pre-commit-config.yaml
, which should fix the issue and prevent it from happening again in the future.