Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versions to mypy hook's additional dependencies #321

Merged
merged 3 commits into from
Apr 11, 2022

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Mar 19, 2022

I was recently introduced to Ward, and I really like the look and feel of it! I like to write my tests with mypy's strict mode, so I wanted to see if I could help with things like #261.

In the meantime, my freshly cloned copy of this repository would not pass mypy checking. Upon investigation, the project depends on rich@^10.0.0, but the pre-commit mypy hook was pulling down latest due to a lack of a version spec. Since rich had breaking changes between 10 and its current of 12, type checking errors were triggered.

This little PR copies the version specs for non-stub typed dependencies from those specified in pyproject.toml over to the additional_dependencies section in .pre-commit-config.yaml, which should fix the issue and prevent it from happening again in the future.

@codecov
Copy link

codecov bot commented Mar 19, 2022

Codecov Report

Merging #321 (d42e0c3) into master (207757e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #321   +/-   ##
=======================================
  Coverage   84.54%   84.54%           
=======================================
  Files          21       21           
  Lines        1851     1851           
  Branches      284      284           
=======================================
  Hits         1565     1565           
  Misses        242      242           
  Partials       44       44           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 207757e...d42e0c3. Read the comment docs.

@darrenburns darrenburns merged commit d919768 into darrenburns:master Apr 11, 2022
@darrenburns
Copy link
Owner

Thanks @mcous!

@mcous mcous deleted the spec-mypy-deps branch September 7, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants