-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update type annotations, make Ward pass mypy
, distribute type annotations via PEP561
#261
Labels
Comments
darrenburns
added
enhancement
New feature or request
good first issue
Good for newcomers
labels
Jun 10, 2021
darrenburns
changed the title
Update type annotations, make Ward pass
Update type annotations, make Ward pass Jun 10, 2021
mypy
mypy
, distribute type annotations via PEP561
#265 is the first but not final step here |
The only thing that remains to be done now is the Line 98 in a4a0b7c
I.e. a few private modules and tests are still not type checked. |
@darrenburns, this issue has already been implemented a long time ago. However, it looks like it's time to close it. |
With pylance, I still get:
For |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Type annotations have been used for the purpose of improving IDE code assistance so far.
MyPy has not been run, and this means that Ward currently does not pass type checking.
We should update the type annotations to ensure Ward passes
mypy
.After this, we can add a build step to check the annotations on CI, and distribute the annotations via PEP561.
The text was updated successfully, but these errors were encountered: