-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storers): Add a new NutsMemcached storage backend built on NutsDB #452
Draft
vejipe
wants to merge
6
commits into
master
Choose a base branch
from
feat/storers/add-nuts-memcached
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vejipe
force-pushed
the
feat/storers/add-nuts-memcached
branch
7 times, most recently
from
February 13, 2024 13:25
9a3071d
to
95cace4
Compare
vejipe
force-pushed
the
feat/storers/add-nuts-memcached
branch
from
March 5, 2024 14:15
182d3aa
to
7578024
Compare
vejipe
force-pushed
the
feat/storers/add-nuts-memcached
branch
from
April 24, 2024 12:20
7578024
to
086ede5
Compare
✅ Deploy Preview for teal-sprinkles-4c7f14 canceled.
|
In this commit NutsMemcached behave just like Nuts.
In this commit cache values are moved to memcached and only keys are kept in Nuts.
vejipe
force-pushed
the
feat/storers/add-nuts-memcached
branch
from
April 29, 2024 12:35
3a033bd
to
92c02be
Compare
2024-04-29T12:45:31.072Z-iPad_Pro_landscape.jpeg |
2024-04-30T13:36:50.806Z-iPad_Pro_landscape.jpeg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new storage backend:
NutsMemcached
. It is composed of both NutsDB and Memcached (i.e., two layers storage).Layer 1:
Keys+Headers
alone are stored in NutsDB in RAM to take advantage of its fast prefix search.Layer 2: Keys+Values are stored in Memcached to take advantage of its advanced RAM+disk eviction system and hard limits on RAM and disk usage.
Note: since NutsDB has no preemptive eviction system, keys would remain until the end of their TTL, while key+values stored in Memcached could be evicted. Question: could we bring back
HintBPTSparseIdxMode
which was very efficient for caching many keys.Note: prefix search is not (easily?) supported on Memcached alone.
References
HintBPTSparseIdxMode
was removed in this PR: refactor: Remove the 3rd mode nutsdb/nutsdb#456, last release with the "3rd mode" is v0.14.0.