Fix tview ux #244
Merged
Fix tview ux #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or before the port to tview
Sirpyerre
reviewed
Nov 9, 2024
| return nil | ||
| } | ||
|
|
||
| func (t *Tui) setupPagination() { | ||
| t.aw.pagination = tview.NewTextView().SetText("1 / 10") | ||
| t.aw.pagination = tview.NewTextView().SetText(fmt.Sprintf("%4d / %4d", 1, 1)) |
There was a problem hiding this comment.
Porque se cambia el SetText("1 / 10")?
Sirpyerre
reviewed
Nov 9, 2024
| @@ -112,6 +112,8 @@ func (t *Tui) setupQueries() { | |||
| return event | |||
| } | |||
|
|
|||
| t.aw.pagination.SetText(fmt.Sprintf("%4d / %4d", 1, 1)) | |||
There was a problem hiding this comment.
¿Que significa estofmt.Sprintf("%4d / %4d", 1, 1), se setea un solo elemento? No sería más sinificativo si se colocan constantes o no vale la pena?
ThiagoMowszet
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I just realized that the ux was a little broken compared the previous behaviors before the ports.
Changes
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: