-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tview #240
Merged
Merged
Add tview #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiagoMowszet
approved these changes
Nov 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested it and it works great, congratulations, great migration! 💯🖖
ThiagoMowszet
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice update!
* docs(demo-gif): update the gif with the new version * docs(typo): fix a typo * add local file * fix url * remove old gif
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to tview as TUI library
Description
This project started out using gocui as TUI library but I quickly regretted that decision, since it's been 3 years since the last meaningful commit. At some point, I forked the library to add the tabs feature I used the database's metadata views.
At the beginning of the year I planned out to migrate the app to bubbletea, but I couldn't worked on it due to multiple reasons (personal and professional reasons), until now, but I didn't migrate the app to the library mentioned above because I found out that wasn't a good fit for the way dblab works.
Then. I came across a tutorial on tview and I considered it as a potential option for dblab. Finally, I read some tutorials on the matter and quickly found that they have a database client demo that could serve as the foundation layer of the migration to it.
The final object of the migration to a new TUI library is being able to add more modern and flexible features to the client, Gocui was very limited and the fact that was very outdated adds more to it. After landing this change we can scope out the addition of more ambitious features and more database management systems.
To accomplish the migration, this PR removes the
gui
package and adds a new one calledtui
. Also, it removes my forked library from the dblab's dependency graph and addstview
as new dependency.Fixes #198
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I ran the test databases I have for testing and ran the new client against them.
Checklist: