Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sql server #222

Merged
merged 10 commits into from
Jul 1, 2024
Merged

Sql server #222

merged 10 commits into from
Jul 1, 2024

Conversation

danvergara
Copy link
Owner

@danvergara danvergara commented Jun 13, 2024

SQL Server

Description

This PR introduces SQL Server support to dblab.

Screenshot from 2024-06-25 21-56-46

Fixes #188

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested out every kind connection against a container.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@danvergara danvergara self-assigned this Jun 13, 2024
@danvergara danvergara added the kind/enhancement New feature or request label Jun 13, 2024
Copy link
Collaborator

@ThiagoMowszet ThiagoMowszet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excelentes cambios! que bueno poder seguir teniendo mas compatibilidad con mas drivers. 💯 🖖

@danvergara danvergara marked this pull request as ready for review June 28, 2024 17:14
@danvergara danvergara merged commit 81e200c into main Jul 1, 2024
8 checks passed
@danvergara danvergara deleted the sql-server branch July 1, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Microsoft SQL Server driver
2 participants