Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove validation on sqlite database file extension #215

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

danvergara
Copy link
Owner

@danvergara danvergara commented Jun 10, 2024

Remove validation on sqlite database file extension

Description

It is up to the user to provide a valid file no matter the extension

Fixes #211

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Copy the existing dblab.db file with a new extension and ran dblab against it.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

it is up to the user to provide a valid file no matter the extension
@danvergara danvergara self-assigned this Jun 11, 2024
@danvergara danvergara merged commit 8a9cf54 into main Jun 17, 2024
8 checks passed
@danvergara danvergara deleted the valid-sqlite-extensions branch June 17, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RSD Sqlite not accepted
1 participant