Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a config file for golangci-lint #185

Merged
merged 4 commits into from
Aug 14, 2023
Merged

add a config file for golangci-lint #185

merged 4 commits into from
Aug 14, 2023

Conversation

danvergara
Copy link
Owner

Add config for golangci-lint

Description

This adds a config file called .golangci.yml to replace golint with revive, since the former is deprecated.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

This runs in the CI and just passed the tests.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@danvergara danvergara added the intermediate Good for intermediate developers label Aug 14, 2023
@danvergara danvergara merged commit 1b43eac into main Aug 14, 2023
14 checks passed
@danvergara danvergara deleted the replace-golint branch August 14, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
intermediate Good for intermediate developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants