Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client refactor #183

Merged
merged 6 commits into from
Aug 15, 2023
Merged

Client refactor #183

merged 6 commits into from
Aug 15, 2023

Conversation

danvergara
Copy link
Owner

@danvergara danvergara commented Aug 6, 2023

Client refactor

Description

The code involved with the queries build up is too attached to the client and hard-coded, adding a new database comes down to adding a new case to a switch, which is not optimal. The idea is refactor the client and abstract away the way queries are performed. This way, adding a new database will be basically a new struct implementing the databaseQuerier interface.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Ran the test suite and QA'd every database supported.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@danvergara danvergara marked this pull request as ready for review August 14, 2023 23:55
@danvergara danvergara added kind/enhancement New feature or request expert Good for advanced developers labels Aug 15, 2023
@danvergara danvergara merged commit b1eefd1 into main Aug 15, 2023
14 checks passed
@danvergara danvergara deleted the client-refactor branch August 15, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
expert Good for advanced developers kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants