fix: Fetch manifest with credentials over CORS #5156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When behind authentication (for eg: Cloudflare Access), browsers won't send credentials when fetching the manifest file by default. To fix, this change adds `crossorigin="use-credentials"` to the manifest link tag which allows the browser to attach credentials. Because of limitations with Vite, for now this needs to happen as a manual post build step.
samvrlewis
commented
Jan 1, 2025
| /<link\s+rel=["']manifest["']([^>]*)>/i, | ||
| (_, attributes) => `<link rel="manifest"${attributes} crossorigin="use-credentials">` | ||
| ); | ||
| await writeFile(indexPath, html); |
There was a problem hiding this comment.
Happy to hear if there's a better way of doing this. I tried initially with a plugin that used transformIndexHtml but it appears this runs before the manifest link is injected, this approach was the only way I could get it to work.
Slightly frustrating that there isn't an easier way to configure this in vite!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When behind authentication (for eg: Cloudflare Access), browsers won't send credentials when fetching the manifest file by default.
To fix, this change adds
crossorigin="use-credentials"to the manifest link tag which allows the browser to attach credentials. Because of limitations with Vite, for now this needs to happen as a manual post build step.Change Type
Please delete any irrelevant options.
Testing
Ran
npm run frontendand ensured themanifestlink inclient/dist/index.htmlhad the expectedcrossoriginattribute.Test Configuration:
Checklist
Please delete any irrelevant options.