Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add balance for newly registered user #4498

Closed

Conversation

dennis531
Copy link
Contributor

@dennis531 dennis531 commented Oct 22, 2024

Summary

Add configuration REGISTRATION_BALANCE to grant new users a default balance at registration. Simplifies the implementation of a balance-accruing system.

Related #2687

Change Type

Please delete any irrelevant options.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Testing

Please describe your test process and include instructions so that we can reproduce your test. If there are any important variables for your testing configuration, list them here.

Test Configuration:

Checklist

Please delete any irrelevant options.

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.
  • A pull request for updating the documentation has been submitted.

@noobskies
Copy link

Does this work for SSO accounts? google, discord etc

@dennis531
Copy link
Contributor Author

Does this work for SSO accounts? google, discord etc

Yes, because the createUser method is called in the createSocialUser method if the configuration ALLOW_SOCIAL_REGISTRATION is enabled, see

const newUserId = await createUser(update);
.

@xixingya
Copy link

xixingya commented Nov 8, 2024

This PR is very useful to me

@danny-avila
Copy link
Owner

Thanks, I merged #4486 which is the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants