Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worked on delete functional #61

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ShahIsCoding
Copy link

hi @danishzayan,
I have fixed the issue using localStorage to storing id of deleted card,
Screenshot (4)
Screenshot (5)

@netlify
Copy link

netlify bot commented Oct 2, 2023

Deploy Preview for your-quotess ready!

Name Link
🔨 Latest commit 864d926
🔍 Latest deploy log https://app.netlify.com/sites/your-quotess/deploys/651b1cd9358d860008042bc3
😎 Deploy Preview https://deploy-preview-61--your-quotess.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@danishzayan
Copy link
Owner

@ShahIsCoding not fixed when i refresh page then quotes is not deleting...

@ShahIsCoding
Copy link
Author

Hi @danishzayan ,
I think I didn't completely get what you want to be fixed in the issue, Could you break it down a bit so I can completely understand it?

@danishzayan
Copy link
Owner

Hi @danishzayan , I think I didn't completely get what you want to be fixed in the issue, Could you break it down a bit so I can completely understand it?

when a user post a quotes your own device then that user can delete your qutoes not delete by other user and without authentication. 😊 and you have fix the issue correctly but i refresh the page and try to delete so it is not deleting...

@danishzayan danishzayan added bug Something isn't working good first issue Good for newcomers labels Oct 2, 2023
@ShahIsCoding
Copy link
Author

@danishzayan i have made the changes its working now

@ShahIsCoding
Copy link
Author

@danishzayan could you add hactoberfest tags in this pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants