feat: add RSD instrumentation service support #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmissmann
requested changes
Apr 12, 2024
ios/listdevices.go
Outdated
| @@ -82,6 +82,10 @@ func NewReadDevices() ReadDevicesType { | |||
| return data | |||
| } | |||
|
|
|||
| func (device *DeviceEntry) SupportsRsd() bool { | |||
There was a problem hiding this comment.
Exported methods should have some documentation
There was a problem hiding this comment.
done :D 22ba1b1
ios/instruments/helper.go
Outdated
| @@ -24,6 +25,10 @@ func (p loggingDispatcher) Dispatch(m dtx.Message) { | |||
| } | |||
|
|
|||
| func connectInstruments(device ios.DeviceEntry) (*dtx.Connection, error) { | |||
| if device.SupportsRsd() { | |||
fish-sauce
added a commit
to kvs-coder/go-ios
that referenced
this pull request
Apr 29, 2024
michal-przytarski
force-pushed
the
rsd-instrumentation-service
branch
from
5dfc702
to
e84ebf1
Compare
|
Hi |
I would still merge it, but I can't. It says |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.