Skip to content

Commit

Permalink
Merge pull request #121 from danielgtaylor/fix-windows-syscall-handle
Browse files Browse the repository at this point in the history
fix: build on windows
  • Loading branch information
danielgtaylor committed May 2, 2022
2 parents 61c7ba4 + bd59d73 commit 8a9d9bf
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
11 changes: 10 additions & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,22 @@ name: CI
on: [push]
jobs:
build:
runs-on: ubuntu-latest
name: Build & Test

runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-latest, windows-latest]

steps:
- uses: actions/checkout@v2
- name: Setup go
uses: actions/setup-go@v1
with:
go-version: "1.18"
- run: go test -coverprofile=coverage.txt -covermode=atomic ./...
if: matrix.os == 'ubuntu-latest'
- run: go test
if: matrix.os == 'windows-latest'
- uses: codecov/codecov-action@v1
if: matrix.os == 'ubuntu-latest'
2 changes: 1 addition & 1 deletion cli/auth.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ func (a *BasicAuth) OnRequest(req *http.Request, key string, params map[string]s

if usernamePresent && !passwordPresent {
fmt.Print("password: ")
inputPassword, err := term.ReadPassword(syscall.Stdin)
inputPassword, err := term.ReadPassword(int(syscall.Stdin))
if err == nil {
params["password"] = string(inputPassword)
}
Expand Down

0 comments on commit 8a9d9bf

Please sign in to comment.