Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Swift 5.7 #620

Merged
merged 10 commits into from
Sep 15, 2024
Merged

Drop Swift 5.7 #620

merged 10 commits into from
Sep 15, 2024

Conversation

417-72KI
Copy link
Member

@417-72KI 417-72KI commented Sep 1, 2024

Closes #619

@417-72KI 417-72KI force-pushed the drop-swift-5.7 branch 4 times, most recently from 1a19ef5 to 3dcf5ff Compare September 1, 2024 04:09
@417-72KI 417-72KI force-pushed the drop-swift-5.7 branch 4 times, most recently from a92ad7c to c9bef0b Compare September 1, 2024 04:31
@417-72KI 417-72KI marked this pull request as ready for review September 1, 2024 04:53
strategy:
fail-fast: false
matrix:
xcode: ["13.2.1", "13.4.1", "14.1"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Xcode 14.3 with macOS-14 runner fails on brew install danger-js

Error: Your Xcode (14.3.1 => /Applications/Xcode_14.3.1.app/Contents/Developer) at /Applications/Xcode.app is too outdated.
Please update to Xcode 15.4 (or delete it).
Xcode can be updated from the App Store.

@@ -83,7 +121,7 @@ jobs:
- name: Install danger-js
run: brew install danger/tap/danger-js

- run: make install
- run: make install PREFIX='/opt/homebrew'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In macOS-14 runner, /usr/local is not writable.

mkdir: /usr/local/lib: Permission denied

Copy link
Member

@f-meloni f-meloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@f-meloni f-meloni merged commit 1d085f6 into danger:master Sep 15, 2024
12 checks passed
@417-72KI 417-72KI mentioned this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Swift 5.5 ~ 5.7
2 participants