Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ruby version in Dockerfile to 3.2 #1472 #1473

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update ruby version in Dockerfile to 3.2 #1472 #1473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ jobs:
build:
working_directory: ~/danger
docker:
- image: ruby:2.7
- image: ruby:3.2
environment:
- RAILS_ENV=test
- RACK_ENV=test
Expand Down
2 changes: 1 addition & 1 deletion .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ inherit_mode:
# Defaults can be found here: https://github.com/bbatsov/rubocop/blob/master/config/default.yml

AllCops:
TargetRubyVersion: 2.7
TargetRubyVersion: 3.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing this line causes many lint errors. I think it should be remained as it is for now.

Exclude:
- 'spec/fixtures/**/*'
- 'lib/danger/plugin_support/plugin_parser.rb'
Expand Down
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ cache:
- bundle

rvm:
- 2.7.1
- 3.2.2

bundler_args: "--without documentation --path bundle"

Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM ruby:2.7
FROM ruby:3.2

LABEL "com.github.actions.name"="Danger"
LABEL "com.github.actions.description"="Runs danger in a docker container such as GitHub Actions"
Expand Down