-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update @types/node to ^14 #1259
Draft
glensc
wants to merge
7
commits into
danger:main
Choose a base branch
from
glensc:update-@types/node
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+13
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
glensc
force-pushed
the
update-@types/node
branch
from
March 18, 2022 08:15
7737496
to
cc3a7b8
Compare
Resolving this error:
Any ideas what the encoding parameter would be here:
perhaps the value is always 'base64' there? as I would drop it and use the default? |
@glensc what you could do is add a parser that converts “string” to BufferEncoding const knownBufferEncodings = [“base64”, TODO]
function verifyEncodingOrThrow(encoding: string): BufferEncoding {
if (knownBufferEncodings.includes(encoding)) {
return encoding as BufferEncoding
}
throw new Error(`Unsupported response buffer encoding ‘${encoding}’)
}
// Typed in Github, so not tested! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires commander update first: