Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing pdf PDDocumentInformation should not be removed #679

Open
wants to merge 1 commit into
base: open-dev-v1
Choose a base branch
from

Conversation

vgalloy
Copy link

@vgalloy vgalloy commented Mar 29, 2021

Motivation:

The method PdfRendererBuilder#usePDDocument(PDDocument) allow the user to provided an existing document. During the process, the information contains in PDDocumentInformation are removed.

Modification:

  • Methods PdfBoxRenderer#setDidValues(PDDocument) add only missing information

@vgalloy vgalloy force-pushed the do-not-remove-existing-information branch from aae3fd4 to ff1b725 Compare March 30, 2021 10:50
Motivation:

The method PdfRendererBuilder#usePDDocument(PDDocument) allow the user to provided an existing document. During the process, the information contains in PDDocumentInformation are removed.

Modification:
* Methods PdfBoxRenderer#setDidValues(PDDocument) add only missing information
@vgalloy vgalloy force-pushed the do-not-remove-existing-information branch from ff1b725 to 5a78dbd Compare March 30, 2021 11:26
@vgalloy
Copy link
Author

vgalloy commented Nov 5, 2021

Any news on this subject ?

@vgalloy
Copy link
Author

vgalloy commented Nov 8, 2021

Hello @danfickle,

You seems to be the main contributor to this project. Could you please take look to this PR and tell me if something goes wrong.

Regards,

Vincent GALLOY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant