Bug fix when nested array in GET query parameters #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is to have indexes in query parameter names where values are array, it fixes following issue:
When a GET request contains such an array
```
let dict: [String : Any] = [
"boundingbox": [["coord1", "coord2"]]
]
```
Here is an error in URL:
swifthttp.com?boundingbox[][]=coord1&boundingbox[][]=coord2
Instead of 1 root element, server reads this parameter as 2 root elements, as seen below
Array (
[0] => Array (
[0] => coord1
)
[1] => Array (
[0] => coord2
)
)
By adding indexes in query parameters here is the fixed URL that is produced:
swifthttp.com?boundingbox[0][0]=coord1&boundingbox[0][1]=coord2
Now server reads the 2 coordinates properly in 1 root element, as seen below
Array (
[0] => Array (
[0] => coord1
[1] => coord2
)
)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its better to have array indexes in query parameter names, such as:
swifthttp.com?array[0]=value1&array[1]=value2It fixes an issue when a GET request contains nested arrays, like the one below:
Currently
Array.createPairsproduces names without indexes:swifthttp.com?boundingbox[][]=coord1&boundingbox[][]=coord2Which causes
boundingboxquery parameter 2 root elements, as seen belowWith this change we will have following URL:
swifthttp.com?boundingbox[0][0]=coord1&boundingbox[0][1]=coord2Now server reads the array properly as 1 root element, as seen below