Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create layout component (WEB-40) #88

Merged

Conversation

climaxmba
Copy link
Contributor

@climaxmba climaxmba commented Apr 29, 2024

chore: create layout component (WEB-40): #86

Ready for review

@climaxmba climaxmba marked this pull request as draft April 29, 2024 18:25
@climaxmba climaxmba marked this pull request as ready for review April 29, 2024 18:55
Copy link
Contributor

@GetBlackBoxSolutions GetBlackBoxSolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@climaxmba
Copy link
Contributor Author

This is very close. Please look at the NextJs documentation.

https://nextjs.org/docs/pages/building-your-application/routing/pages-and-layouts#layout-pattern

I have added the children prop and nested children in <main>. By the way, would it be ok if I added a test for the component?

@GetBlackBoxSolutions GetBlackBoxSolutions merged commit 8bbbde9 into dallassoftwaredevelopers:main May 7, 2024
4 checks passed
@climaxmba climaxmba deleted the WEB-40 branch May 7, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants