Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add non-negative counterparts of --no-XXX options #417

Merged
merged 1 commit into from
May 28, 2024
Merged

Add non-negative counterparts of --no-XXX options #417

merged 1 commit into from
May 28, 2024

Conversation

dlax
Copy link
Member

@dlax dlax commented Apr 19, 2024 •
edited

todo:

  • make sure CLI options take precedence over the configuration, and test that
  • add test coverage
  • update man page and readme maybe

@dlax dlax force-pushed the BooleanOptionalAction branch 10 times, most recently from 50908b9 to 77d1c33 Compare May 24, 2024 10:39
@dlax
Add non-negative counterparts of --no-XXX options
e5dd8ed 
We need to set the default value of "flag" options (those built using
the flag() helper function) to None in order to discriminate unspecified
option (value=None) from unset option (value=False).
@dlax dlax marked this pull request as ready for review May 28, 2024 12:10
@dlax dlax merged commit e5dd8ed into dalibo:master May 28, 2024
3 checks passed
@dlax dlax deleted the BooleanOptionalAction branch May 28, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dlax