Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to 2021 edition #358

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Upgrade to 2021 edition #358

wants to merge 1 commit into from

Conversation

rickwebiii
Copy link

No description provided.

rillian
rillian reviewed Feb 1, 2024
View reviewed changes
Copy link

@rillian rillian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, although I'd address the to_bytes dead code warning by either removing the method or adding something to keep it alive, rather than hiding it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rillian rillian rillian left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rickwebiii @rillian