Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x448 to core. #432

Merged
merged 3 commits into from
Oct 13, 2024
Merged

Add x448 to core. #432

merged 3 commits into from
Oct 13, 2024

Conversation

dajiaji
Copy link
Owner

@dajiaji dajiaji commented Oct 13, 2024

No description provided.

@dajiaji dajiaji force-pushed the add-x448-to-core branch 2 times, most recently from 7867762 to 369d812 Compare October 13, 2024 03:01
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.25000% with 81 lines in your changes missing coverage. Please review.

Project coverage is 88.90%. Comparing base (7daa676) to head (5c49d88).

Files with missing lines Patch % Lines
packages/core/src/kems/dhkemPrimitives/x448.ts 62.84% 80 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
- Coverage   89.99%   88.90%   -1.10%     
==========================================
  Files          56       58       +2     
  Lines        4149     4380     +231     
  Branches      385      408      +23     
==========================================
+ Hits         3734     3894     +160     
- Misses        414      484      +70     
- Partials        1        2       +1     
Flag Coverage Δ
unittests 88.90% <66.25%> (-1.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dajiaji dajiaji merged commit addc2e6 into main Oct 13, 2024
14 checks passed
@dajiaji dajiaji deleted the add-x448-to-core branch October 18, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants