Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DhkemX25519HkdfSha256 for @hpke/core. #430

Merged
merged 3 commits into from
Oct 12, 2024
Merged

Conversation

dajiaji
Copy link
Owner

@dajiaji dajiaji commented Oct 12, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 61.13360% with 96 lines in your changes missing coverage. Please review.

Project coverage is 89.76%. Comparing base (8c099f7) to head (868300d).

Files with missing lines Patch % Lines
packages/core/src/kems/dhkemPrimitives/x25519.ts 57.52% 96 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
- Coverage   91.85%   89.76%   -2.09%     
==========================================
  Files          54       56       +2     
  Lines        3917     4164     +247     
  Branches      369      387      +18     
==========================================
+ Hits         3598     3738     +140     
- Misses        318      425     +107     
  Partials        1        1              
Flag Coverage Δ
unittests 89.76% <61.13%> (-2.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dajiaji dajiaji merged commit 7ec3ee7 into main Oct 12, 2024
14 checks passed
@dajiaji dajiaji deleted the add-x25519-to-core branch October 18, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants