Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumping node orb to enable pnpm #485

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

ramykl
Copy link
Contributor

@ramykl ramykl commented Sep 11, 2024

Closes #442

@cypress-app-bot
Copy link
Collaborator

@ramykl
Copy link
Contributor Author

ramykl commented Sep 26, 2024

@jennifer-shehane able to get someone to have a look at this small PR?

@MikeMcC399 MikeMcC399 added the type: enhancement New feature or request label Oct 2, 2024
@ramykl
Copy link
Contributor Author

ramykl commented Oct 21, 2024

@MikeMcC399 @jennifer-shehane It would be really good to get this merged so pnpm is finally working as described in the readme for this

@MikeMcC399
Copy link
Collaborator

@ramykl

It would be really good to get this merged so pnpm is finally working as described in the readme for this

Sorry that I can't help here. I'm an external contributor and I have no privileges to merge PRs or to release new versions of the Orb. Such actions need to be handled by the Cypress.io team themselves.

@jennifer-shehane jennifer-shehane merged commit b8ebfb6 into cypress-io:master Oct 29, 2024
7 of 8 checks passed
@jennifer-shehane
Copy link
Member

@ramykl
Copy link
Contributor Author

ramykl commented Nov 4, 2024

@jennifer-shehane I'm trying to track down why it's failing.... for whatever reason it's install version 8 of pnpm instead of version 9... but can't see any reason why in either the node orb or the circleci-orb... will provide a fix whenever I can track it down

@ramykl ramykl deleted the bump-node-orb-verion branch November 4, 2024 14:04
@ramykl
Copy link
Contributor Author

ramykl commented Nov 4, 2024

@jennifer-shehane I think this #492 will fix the failing test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package manager:PNPM not supported in circleci orb
4 participants