Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jupyter extensions to userprofile handler #641

Merged

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Nov 1, 2024

Partially addresses #470

List Jupyter server extensions that provide web applications (i.e. cylc & lab) in the "userprofile".

I might see if I can get the implementation into Jupyter Server in the future (opened jupyter-server/jupyter_server#1469). We will probably want to continue merging this into our own userprofile endpoint for convenience though.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users (it doesn't)
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders oliver-sanders self-assigned this Nov 1, 2024
@oliver-sanders oliver-sanders force-pushed the list-jupyter-server-extensions branch from a638895 to 66cc74f Compare November 1, 2024 16:22
@oliver-sanders oliver-sanders added this to the 1.6.0 milestone Nov 1, 2024
@oliver-sanders oliver-sanders marked this pull request as ready for review November 1, 2024 16:23
@oliver-sanders oliver-sanders force-pushed the list-jupyter-server-extensions branch from 66cc74f to ebe5306 Compare November 4, 2024 10:34
cylc/uiserver/handlers.py Outdated Show resolved Hide resolved
@oliver-sanders oliver-sanders merged commit 299f26b into cylc:master Nov 28, 2024
5 of 6 checks passed
@oliver-sanders oliver-sanders deleted the list-jupyter-server-extensions branch November 28, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants